Adding linkcheck (and check for other build problems)#304
Adding linkcheck (and check for other build problems)#304Mukulikaa merged 11 commits intonumpy:mainfrom
Conversation
bsipocz
added
infrastructure
The .com link is dead, the .in link consistently times out.
Fixes errors (and borked rendering) in static eq tutorial.
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
Great - thanks @bsipocz ! This is a definite improvement
For whatever reason the CI run borked the first time through - when I re-ran it it failed as expected (including the errors in the log). I took the liberty of pushing up fixes for those errors. Most of them were either removing or replacing dead links (see individual commits for comments).
The last one is the latex rendering error which has been present for a while. I finally went about searching how to fix it :) - the build errors are gone and the rendering now seems to be fixed (scroll down a bit from that anchor to see the rendered TeX - compare with what's currently deployed).
Circleci in particular seems a bit flaky (there have been a couple timeouts related to this PR) - but there's no evidence it's related to the --strict. My vote would be to put this in and simply keep an eye on circleci to see if we continue getting extraneous timeouts.
Thanks again @bsipocz ! I approve this but will let someone else merge so folks have a chance to look the changes I pushed up too!
|
Thanks Ross! I meant to come back to this, but coming back to a fixed up PR is even better 😀 I'll also let the others have a look, I myself are happy with your suggested changes. |
* Adding linkcheck (and check for other build problems) * DOC: rm dead quansight link. * DOC: Update link to boolean indexing. * DOC: Rm dead link to machinelearningmaster.com * DOC: Replace explicit link with doc xlink. * DOC: replace dead nih blog link with arxiv.org * DOC: Update imageio link. * Rm dead link to raddq.com. * DOC: rm links to cpcb (in/com). The .com link is dead, the .in link consistently times out. * TEX: Add column specifications to tables. Fixes errors (and borked rendering) in static eq tutorial. * DOC: Rm sciencedirect link (403) --------- Co-authored-by: Ross Barnowski <rossbar@caltech.edu> 7b2b1b6
3 participants
This will close #156
I expect seeing broken links here which should be fixed.