Skip to content

chore: remove unused SyncSource classes #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaibhavtiwari33 merged 2 commits into from
Mar 28, 2026
Merged

chore: remove unused SyncSource classes #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ccd6b
chore: remove unused SyncSource classes
vaibhavtiwari33 Mar 28, 2026
bd70217
chore: fix linting
vaibhavtiwari33 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions packages/pynumaflow/tests/source/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from collections.abc import Iterable

from pynumaflow.shared.asynciter import NonBlockingIterator
from pynumaflow.sourcer import ReadRequest, Message, UserMetadata
from pynumaflow.sourcer import (
Expand Down Expand Up @@ -56,28 +54,6 @@ async def partitions_handler(self) -> PartitionsResponse:
return PartitionsResponse(partitions=mock_partitions())


class SyncSource(Sourcer):
def read_handler(self, datum: ReadRequest) -> Iterable[Message]:
payload = b"payload:test_mock_message"
keys = ["test_key"]
offset = mock_offset()
event_time = mock_event_time()
for i in range(10):
yield Message(payload=payload, keys=keys, offset=offset, event_time=event_time)

def ack_handler(self, ack_request: AckRequest):
return

def nack_handler(self, nack_request: NackRequest):
return

def pending_handler(self) -> PendingResponse:
return PendingResponse(count=10)

def partitions_handler(self) -> PartitionsResponse:
return PartitionsResponse(partitions=mock_partitions())


def read_req_source_fn() -> ReadRequest:
request = source_pb2.ReadRequest.Request(
num_records=10,
Expand Down Expand Up @@ -128,20 +104,3 @@ async def pending_handler(self) -> PendingResponse:

async def partitions_handler(self) -> PartitionsResponse:
raise RuntimeError("Got a runtime error from partition handler.")


class SyncSourceError(Sourcer):
def read_handler(self, datum: ReadRequest) -> Iterable[Message]:
raise RuntimeError("Got a runtime error from read handler.")

def ack_handler(self, ack_request: AckRequest):
raise RuntimeError("Got a runtime error from ack handler.")

def nack_handler(self, nack_request: NackRequest):
raise RuntimeError("Got a runtime error from nack handler.")

def pending_handler(self) -> PendingResponse:
raise RuntimeError("Got a runtime error from pending handler.")

def partitions_handler(self) -> PartitionsResponse:
raise RuntimeError("Got a runtime error from partition handler.")
Loading