fix(ui): adjust sidebar versions spacing#1641
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request updates CSS classes and spacing in two Vue components. In app/components/CollapsibleSection.vue the button's size and margin classes are changed (replacing explicit width/height with size token and adjusting negative end margin). In app/components/Package/Versions.vue multiple presentational tweaks were made: semver filter container padding and gap adjustments, icon/chevron sizing swapped to size tokens, placeholder width increased, and button spacing/alignment tweaks. No JavaScript logic, event handling, bindings or exported declarations were modified. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/Package/Versions.vue (1)
577-602: Loading spinner sizing token inconsistent with the updated chevron.Line 595 was updated to
size-3for the chevron, but line 589 (the sibling loading spinner, rendered inside the same button) still usesw-3 h-3. Likewise, lines 746 and 752 inside the updated "Other versions" wrapper span (line 742) retainw-3 h-3.♻️ Proposed fix — align spinner tokens with the chevron
- class="i-svg-spinners:ring-resize w-3 h-3" + class="i-svg-spinners:ring-resize size-3"Apply the same change to the equivalent span at line 746, and update the chevron span at line 752:
- class="w-3 h-3 transition-transform duration-200 rtl-flip" + class="size-3 transition-transform duration-200 rtl-flip"
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Everything is great, thanks ❤️ |


🔗 Linked issue
resolves #1565