Skip to content

Comments

feat(i18n): add missing German translations#1628

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
tomvoet:feat/i18n/add_missing_german_translations
Feb 25, 2026
Merged

feat(i18n): add missing German translations#1628
danielroe merged 1 commit intonpmx-dev:mainfrom
tomvoet:feat/i18n/add_missing_german_translations

Conversation

@tomvoet
Copy link
Contributor

@tomvoet tomvoet commented Feb 24, 2026

🧭 Context

Added german translations for the following i18n keys:

  • package.versions:
    • distribution_range_date_same_year
    • distribution_range_date_multiple_years
    • grouping_versions_title
    • grouping_versions_all
    • grouping_versions_only_recent
    • grouping_usage_title
    • grouping_usage_all
    • grouping_usage_low
  • compare.packages.copy_as_markdown

Note: I find the grouping_usage_* wording a bit misleading.

All hides low-usage versions and Low includes them. Maybe we could do something like:

  • Significant vs. All
  • ≥1% vs All
  • a simple Show low usage-Toggle

I've directly translated these two keys for now, to avoid diverging from the existing English strings.

This is also mentioned in #1612

@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 24, 2026 8:07pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 24, 2026 8:07pm
npmx-lunaria Ignored Ignored Feb 24, 2026 8:07pm

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

📝 Walkthrough

Walkthrough

This pull request adds German localisation strings to the de-DE.json translation file. The changes introduce new UI text keys for distribution date range formatting with year variants, version and usage grouping labels, and copy-as-markdown functionality. Nine new translation entries are added with no modifications to existing strings or functional logic.

Possibly related PRs

Suggested reviewers

  • danielroe
  • trueberryless
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately details the German translations being added for i18n keys, including distribution date ranges, version grouping, and usage grouping labels.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
lunaria/files/de-DE.json (1)

296-305: Same grouping‑label concern as the main de‑DE locale.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c52d259 and 84f6456.

📒 Files selected for processing (2)
  • i18n/locales/de-DE.json
  • lunaria/files/de-DE.json

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 25, 2026
Merged via the queue into npmx-dev:main with commit fcd5b7d Feb 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants