Fix timer button negative countdown bug and enhance example app#34
Merged
ProjectAJ14 merged 1 commit intomainfrom Mar 23, 2026
Merged
Fix timer button negative countdown bug and enhance example app#34ProjectAJ14 merged 1 commit intomainfrom
ProjectAJ14 merged 1 commit intomainfrom
Conversation
Closes #24 - Clamp timeOutInSeconds to 0 when negative, preventing display of negative countdown values like "-5s" - Cancel pending timer before reset to prevent double-decrement bug - Add guard in _updateTime to reject non-positive counter values - Extract _safeTimeout getter to deduplicate clamping logic - Remove unnecessary async on timer callback - Add tests for negative timeOutInSeconds and counter clamping - Restructure example app into app.dart, home_page.dart, theme.dart - Upgrade example app to Material 3 theming with ColorScheme Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 63 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeOutInSecondsto 0 when negative, preventing display of values like "-5s"_onPressed, preventing a spurious extra tick_updateTime: Early return when counter is already <= 0_safeTimeoutgetter to deduplicate clamping, remove unnecessaryasyncon timer callbacktimeOutInSecondsinput is clamped and counter never goes below 0app.dart,home_page.dart,theme.dartwith Material 3 themingCloses #24
Test plan
flutter test)flutter analyzepasses with no issuestimeOutInSecondstimeOutInSecondsis negative🤖 Generated with Claude Code