Skip to content

chore(ui): use compiled exports by default #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avivkeller wants to merge 2 commits into from
+8 −9
Closed

chore(ui): use compiled exports by default #8626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d551a78
chore(ui): use compiled exports by default
avivkeller Feb 13, 2026
1735d5f
fixup!
avivkeller Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ jobs:
working-directory: packages/${{ matrix.package }}
run: |
# Check if a custom publish script exists in package.json
if jq -e '.scripts.release' package.json > /dev/null; then
pnpm run release
if jq -e '.scripts.compile' package.json > /dev/null; then
pnpm run compile
fi

# Then publish the package to npm
Expand Down
2 changes: 1 addition & 1 deletion apps/site/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "Bundler",
"customConditions": ["default"],
"customConditions": ["uncompiled"],
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "react-jsx",
Expand Down
9 changes: 4 additions & 5 deletions packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
"type": "module",
"exports": {
"./*": {
"rolldown": [
"default": [
"./dist/*",
"./dist/*.js",
"./dist/*/index.js"
],
Comment on lines 6 to 11
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the exports default condition to ./dist/* will make workspace consumers (e.g. apps/site) resolve @node-core/ui-components/... to dist, but dist/ is not present in the repo and this package does not currently participate in the Turbo build/dev pipeline. As-is, local dev/CI builds that import @node-core/ui-components/... are likely to fail unless pnpm run compile is executed beforehand. Consider either ensuring compile runs automatically before consumers build/dev (e.g. add a build script + Turbo task outputs for dist/** and make dependent tasks depend on it), or keep the workspace-default pointing at src and only use dist as default for published artifacts via conditions/publish config.

Copilot uses AI. Check for mistakes.
"default": [
"uncompiled": [
"./src/*",
"./src/*.tsx",
"./src/*/index.tsx",
Expand All @@ -28,7 +28,6 @@
"compile:css": "postcss --dir dist --base src \"src/**/*.module.css\" src/styles/index.css",
"compile": "node --run compile:ts && node --run compile:css",
"compile:watch": "concurrently -k \"node --run compile:ts -- --watch\" \"node --run compile:css -- --watch\"",
"release": "node --run compile",
"lint": "node --run lint:js && node --run lint:css",
"lint:css": "stylelint \"**/*.css\" --allow-empty-input --cache --cache-strategy=content --cache-location=.stylelintcache",
"lint:css:fix": "node --run lint:css -- --fix",
Expand Down Expand Up @@ -90,12 +89,12 @@
},
"imports": {
"#ui/*": {
"rolldown": [
"default": [
"./dist/*",
"./dist/*.js",
"./dist/*/index.js"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports["#ui/*"].default now points to ./dist/*, but a lot of source files (and Storybook preview) import #ui/... while running directly from src (without a preceding compile step). Since dist/ isn't present by default, Storybook/tests/dev in this repo are likely to break unless you either (1) run compile before those tasks, or (2) configure the relevant runners/bundlers to resolve the uncompiled condition (e.g. Node --conditions=uncompiled, and webpack/Storybook resolve.conditionNames including uncompiled).

Suggested change
"./dist/*/index.js"
"./dist/*/index.js",
"./src/*",
"./src/*.tsx",
"./src/*/index.tsx",
"./src/*.ts",
"./src/*/index.ts"

Copilot uses AI. Check for mistakes.
],
"default": [
"uncompiled": [
"./src/*",
"./src/*.tsx",
"./src/*/index.tsx",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-components/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "bundler",
"customConditions": ["default"],
"customConditions": ["uncompiled"],
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "react-jsx",
Expand Down
Loading