Open
Conversation
Original commit message:
optimize ascii fast path in WriteUtf8V2
Change-Id: If28168cb4395b953d0ec642ef4fc618ce963dbcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124103
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Erik Corry <erikcorry@chromium.org>
Reviewed-by: Erik Corry <erikcorry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103542}
Refs: v8/v8@64b36b4
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks V8 commit
64b36b441179(ASCII fast path optimization inWriteUtf8V2).This optimizes the
WriteUtf8V2path for ASCII-only one-byte strings by using SIMD-accelerated validation (simdutf::validate_ascii) followed by a bulkmemcpy, instead of encoding byte-by-byte through the generic UTF-8 path.Changes:
deps/v8/src/strings/unicode-inl.h— AddedIsAsciiOneByteStringtemplate specializations and ASCII fast path inEncodedeps/v8/src/strings/unicode.h— AddedIsAsciiOneByteStringdeclarationscommon.gypi— Incremented embedder string (-node.11→-node.12)References:
v24.x-staging, maintainers requested rebase tomain)