src: fix --build-sea default executable path#61708
Open
alexsch01 wants to merge 5 commits intonodejs:mainfrom
Open
src: fix --build-sea default executable path#61708alexsch01 wants to merge 5 commits intonodejs:mainfrom
--build-sea default executable path#61708alexsch01 wants to merge 5 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
Author
|
Just compiled it and it runs as expected |
Member
|
Thanks for the PR, can you add a test? I think you may need to use child_process.execSync and tweak the path variables a bit to reproduce it with a shell. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61708 +/- ##
==========================================
- Coverage 89.75% 89.73% -0.02%
==========================================
Files 674 674
Lines 204416 204424 +8
Branches 39285 39282 -3
==========================================
- Hits 183472 183449 -23
- Misses 13227 13264 +37
+ Partials 7717 7711 -6
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Feb 6, 2026
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
joyeecheung
reviewed
Feb 6, 2026
|
|
||
| const fixturesDir = fixtures.path('sea', 'basic'); | ||
| const tempDir = tmpdir.path; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| tmpdir.refresh(); |
Comment on lines
+21
to
+22
| resolve(fixturesDir, 'sea-config.json'), | ||
| resolve(tempDir, 'sea-config.json'), |
Member
There was a problem hiding this comment.
Suggested change
| resolve(fixturesDir, 'sea-config.json'), | |
| resolve(tempDir, 'sea-config.json'), | |
| fixtures.path('sea-config.json'), | |
| tmpdir.resolve('sea-config.json'), |
Comment on lines
+26
to
+27
| resolve(fixturesDir, 'sea.js'), | ||
| resolve(tempDir, 'sea.js'), |
Member
There was a problem hiding this comment.
Suggested change
| resolve(fixturesDir, 'sea.js'), | |
| resolve(tempDir, 'sea.js'), | |
| fixtures.path('sea.js'), | |
| tmpdir.resolve('sea.js'), |
|
|
||
| spawnSyncAndAssert( | ||
| process.execPath, | ||
| ['--build-sea', resolve(tempDir, 'sea-config.json')], { |
Member
There was a problem hiding this comment.
Suggested change
| ['--build-sea', resolve(tempDir, 'sea-config.json')], { | |
| ['--build-sea', tmpdir.resolve('sea-config.json')], { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61579