fix(share): permission

[alperozturk96]

Fixes

Updates the view to correctly reflect share fields.
De-duplicates share fetch logic and standardizes its usage.
Fixes share update logic.
Fixes sending share emails.
Fixes displaying email addresses in the search bar.
Fixes icon alignment issues.
Replaces buttons with Material 3 icon buttons.
Removes non-existent actions for notes.
Warns users when selecting a weak share password instead of failing silently.
Ensures cached share data is removed when a share is deleted.
Clarifies function naming to distinguish between get and fetch.
Fixes update POST request body and aligns it with the web implementation.
Unifies share permission setting and checking logic.
Implements allow download and sync option for Internal and User share type just like web

Public share fields tests

public_share_field_tests.mp4

Public share set password

public_share_set_password_test.mp4

Internal share tests

internal_share_test.mp4

[alperozturk96]

/backport to stable-4.6

[tobiasKaminsky]

When I click on three dots menu for an interal share, I see "delete link", but it should be "unshare" (or smth like that)

[tobiasKaminsky]

Can you retest this, on web:

• user2 shares a note to user1
• it ends up in /Shared for user1
• not visible in Notes for user1

If yes, this is a bug on Notes web app

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3043.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

@tobiasKaminsky @AndyScherzinger force merge needed