don't filter results while sharing#3782
Open
avinash-0007 wants to merge 1 commit intonextcloud:mainfrom
Open
Conversation
Contributor
|
@avinash-0007 thank you for your contribution, Can you make sure to sign off the commit, to have a green CI |
hamza221
added
bug
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
@avinash-0007 could you please sign-off your commit? Unfortunately we can't do this for you, because it's a mechanism to guarantee that this is your code
| * @param {string} label | ||
| * @param {string} search | ||
| */ | ||
| /* eslint-disable @typescript-eslint/no-unused-vars */ |
Member
There was a problem hiding this comment.
I suggest to drop the arguments from the function instead of the eslint line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share only works by display name right now
Search by email to share calendar is broken completely as there is a filterBy option in vue-select whose return value defaults to return (label || '').toLocaleLowerCase().indexOf(search.toLocaleLowerCase()) > -1
Since we already get our results by searching(DAV & OCS), I don't see why we need the filterBy option in the first place
same as this PR : nextcloud/calendar#5645