fix: replace bare except blocks, deprecated logging.warn, dead code, and mutable default#271
Open
haoyu-haoyu wants to merge 1 commit intoneurolib-dev:masterfrom
Open
fix: replace bare except blocks, deprecated logging.warn, dead code, and mutable default#271haoyu-haoyu wants to merge 1 commit intoneurolib-dev:masterfrom
haoyu-haoyu wants to merge 1 commit intoneurolib-dev:masterfrom
Conversation
…and mutable default
- Replace bare `except:` with `except Exception:` in
`utils/functions.py` (fcd) and
`optimize/evolution/evolutionaryUtils.py` (saveToPypet).
Bare except catches KeyboardInterrupt and SystemExit.
- Replace all `logging.warn()` with `logging.warning()` in
`models/model.py` and `evolutionaryUtils.py`. `logging.warn()`
has been deprecated since Python 3.3.
- Remove unreachable `return 0` dead code in
`utils/loadData.py` loadMatrix method.
- Fix mutable default argument `apply_function_kwargs={}` →
`apply_function_kwargs=None` in `utils/loadData.py`
getDataPerSubject method.
- Fix `== None` → `is None` in `utils/pypetUtils.py` (PEP 8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:withexcept Exception:inutils/functions.py(fcd()) andoptimize/evolution/evolutionaryUtils.py(saveToPypet()). Bareexcept:catchesKeyboardInterruptandSystemExit, preventing users from interrupting long-running simulations.Replace deprecated
logging.warn()withlogging.warning()inmodels/model.py(3 occurrences) andevolutionaryUtils.py(1 occurrence).logging.warn()has been deprecated since Python 3.3.Remove unreachable dead code
return 0afterreturn matrixinutils/loadData.pyloadMatrix()method.Fix mutable default argument
apply_function_kwargs={}→apply_function_kwargs=Nonewith guard inutils/loadData.pygetDataPerSubject()method.Fix
== None→is Noneinutils/pypetUtils.py(PEP 8).Test plan
logging.warning()is the non-deprecated equivalent oflogging.warn()return 0was never reachableNoneguard produces identical empty dict behavior