fix(crud-typeorm): fix sql injection check looping on the first regex…#694
Open
c3dr1cF0rt1n wants to merge 1 commit intonestjsx:masterfrom
c3dr1cF0rt1n:master
Open
fix(crud-typeorm): fix sql injection check looping on the first regex…#694c3dr1cF0rt1n wants to merge 1 commit intonestjsx:masterfrom c3dr1cF0rt1n:master
c3dr1cF0rt1n wants to merge 1 commit intonestjsx:masterfrom
c3dr1cF0rt1n:master
Conversation
Collaborator
|
Merged on rewiko#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be an error on sql injection check, looping exclusively on the first element of the regex array. Also changed the check function from private to protected to allow reusability on deriving classes.