fix: Keep CTRL+C propagated as signal and not as input#21
Open
ValentinTrinque wants to merge 1 commit intomuesli:mainfrom
Open
fix: Keep CTRL+C propagated as signal and not as input#21ValentinTrinque wants to merge 1 commit intomuesli:mainfrom
ValentinTrinque wants to merge 1 commit intomuesli:mainfrom
Conversation
According to the Windows documentation (https://learn.microsoft.com/en-us/windows/console/ctrl-c-and-ctrl-break-signals) > The SetConsoleMode function can disable the ENABLE_PROCESSED_INPUT input mode > for a console's input buffer, so CTRL+C is reported as keyboard input rather > than as a signal. In the windows implementation, we do: ```go var newMode uint32 newMode &^= windows.ENABLE_ECHO_INPUT newMode &^= windows.ENABLE_LINE_INPUT newMode &^= windows.ENABLE_MOUSE_INPUT newMode &^= windows.ENABLE_WINDOW_INPUT newMode &^= windows.ENABLE_PROCESSED_INPUT // This reports CTRL+C as an input rather than as a signal. newMode |= windows.ENABLE_EXTENDED_FLAGS newMode |= windows.ENABLE_INSERT_MODE newMode |= windows.ENABLE_QUICK_EDIT_MODE ``` It should be changed to `newMode |= windows.ENABLE_PROCESSED_INPUT` so we keep the signal propagation.
Author
|
Is this project still maintained ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Windows documentation (https://learn.microsoft.com/en-us/windows/console/ctrl-c-and-ctrl-break-signals)
In the windows implementation, we do:
It should be changed to
newMode |= windows.ENABLE_PROCESSED_INPUTso we keep the signal propagation.