Improve invalid fd error messages for epoll#13
Open
erikgeiser wants to merge 1 commit intomuesli:mainfrom
Open
Improve invalid fd error messages for epoll#13erikgeiser wants to merge 1 commit intomuesli:mainfrom
erikgeiser wants to merge 1 commit intomuesli:mainfrom
Conversation
aymanbagabas
approved these changes
Mar 2, 2024
|
I am pursuing a problem that I am having with go.d.plugin and it is right here. I would suggest that the code not substitute another message has you have done, but use the actual cancelreader error codes. BTW, my problem is that go.d.plugin is not collecting when it is spawned by my server but will work when run from the console or a shell script. The only difference in the logs this error message. The problem started a couple of days ago. |
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 25, 2024
The failure happens only on GH Actions, so I'm doing this test commit to see the underlaying error
cardil
added a commit
to wavesoftware/go-magetasks
that referenced
this pull request
Mar 25, 2024
The failure happens only on GH Actions, so I'm doing this test commit to see the underlaying error
|
Ah, I was about to send a very similar PR as I was confused by the lack of information in these error messages as well (mvdan/sh#1099). @muesli would you be able to review this PR? At least it looks good to me :) |
Owner
|
Will do! |
aymanbagabas
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the error returned by
unix.EpollCtlwas discarded. This PR improves the error messages and includes the file descriptors as they are likely related to any error that can occur. Additionally a -1 file descriptor is caught early with a descriptive error message.