feat: Add --chromium-pref to CLI options#3664
Open
PatrykKuniczak wants to merge 2 commits intomozilla:masterfrom
Open
feat: Add --chromium-pref to CLI options#3664PatrykKuniczak wants to merge 2 commits intomozilla:masterfrom
--chromium-pref to CLI options#3664PatrykKuniczak wants to merge 2 commits intomozilla:masterfrom
Conversation
--chromium-pref` to CLI options--chromium-pref to CLI options
Author
|
Wait a second I'll remove I'm waiting to your response and then i'll quickly adjust this PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basing on #2912, I've taken couple commits and a bunch of code.
I've added request changes of @Rob--W review.
I've converted chromiumPrefs to
Map()because of https://github.com/mozilla/web-ext/pull/2912/changes#r1704363575I hope you'll like that, because you've suggested to convert only
coerceCLICustomChromiumPreferencefunc, but i thought it's good idea to useMap()like it's now, but maybe that's not good idea.I see
web-ext/src/firefox/preferences.js
Line 120 in 308b344
have object
And there's a question, are you want my solution and probably want to convert
coerceCLICustomPreferenceand entireprefto beMap()(In other PR) or want me to revert that change and use object for all places excludingcoerceCLICustomChromiumPreferenceor maybe you want 1 approach here and other incoerceCLICustomPreference(IMO this should be consistent)Let's guide me, how to merge this PR successfully, because a bunch of community of wxt-dev/wxt#137 waiting for this, and i want to do it and use in our code 😸
I hope this is understable and nothing'll block me to do this 😆