Open
Conversation
Contributor
|
Apologies for the slow response - I was out on PTO and then heads down on some other work for a while. @tuyafeng Can you provide a "real life" example (rather than w3schools) of pages that currently don't get detected as readerable as a result of this omission? For context, the only real tradeoff here is for performance - the more tags included, the longer the "readerable" determination takes, and it's designed to be faster (and more "rough guess") than running a full readability pass, if that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some pages have long quoted sections but only a few lines of commentary or intro. Right now,
isProbablyReaderableignoresblockquote, which can make the examples below score 0 (the default options), whereas includingblockquotewould give a score of 9.Example from W3Schools:
I’m thinking it might make sense to factor blockquote into the scoring. If not, I’d love to hear the reasoning—thanks!