wasapi: Simplify OnDefaultDeviceChanged handling.#835
Open
wasapi: Simplify OnDefaultDeviceChanged handling.#835
Conversation
The debounce logic was broken (last_device_change was never updated) ever since the code was introduced. Also remove the same_device check, since we're likely better off without it due to the behaviour observed in https://issues.chromium.org/issues/41186400 If we do want to debounce, it needs to be handled in wasapi_stream_render_loop's reconfigure logic, since we also signal reconfigure_event when we receive AUDCLNT_E_DEVICE_INVALIDATED from WASAPI API calls which wouldn't pass through this logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debounce logic was broken (last_device_change was never updated) ever since the code was introduced.
Also remove the same_device check, since we're likely better off without it due to the behaviour observed in
https://issues.chromium.org/issues/41186400
If we do want to debounce, it needs to be handled in wasapi_stream_render_loop's reconfigure logic, since we also signal reconfigure_event when we receive AUDCLNT_E_DEVICE_INVALIDATED from WASAPI API calls which wouldn't pass through this logic.