Open
Conversation
Author
|
@suhaibmujahid could you please take a look at this PR |
Removed installation of test requirements from the task.
suhaibmujahid
requested changes
Dec 9, 2025
Member
There was a problem hiding this comment.
Why do we need to create a custom hook? Have you tried finding an off-the-shelf solution?
| hooks: | ||
| - id: check-json-indentation | ||
| name: Check JSON Indentation Consistency | ||
| entry: pre-commit/check_json_indentation.py |
Member
There was a problem hiding this comment.
If there isn't an existing hook for this, it would be simpler to use an inline pygrep hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom pre-commit hook to ensure indentation consistency of JSON files. Resolves #2332
Checklist
to-be-announcedtag added if this is worth announcing