Updated not_landed to get user nicks in 1 call and removed the duplicate - Closes #1101#2365
Open
Jubintgh wants to merge 3 commits intomozilla:masterfrom
Open
Updated not_landed to get user nicks in 1 call and removed the duplicate - Closes #1101#2365Jubintgh wants to merge 3 commits intomozilla:masterfrom
Jubintgh wants to merge 3 commits intomozilla:masterfrom
Conversation
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you, @Jubintgh! Please see my comments.
Author
Thanks @suhaibmujahid, I applied your suggestions to improve readability. please let me know your thoughts |
Member
There was a problem hiding this comment.
Thank you! Could you please do another dry-run test?
Also, please link the PR to the issue that will be resolved.1
Footnotes
Jubintgh
changed the title
Jubintgh
changed the title
suhaibmujahid
requested changes
Mar 27, 2024
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
Could you please link to the issue in the PR description instead of the title?
|
|
||
| self.add_auto_ni(bugid, {"mail": assignee, "nickname": nickname}) | ||
|
|
||
| common = all_reviewers & data["reviewers_phid"] |
Member
There was a problem hiding this comment.
Isn't all_reviewers a set?
| if not assignee: | ||
| assignee = max(data["author"], key=data["author"].get) | ||
| nicknames[bugid] = assignee | ||
| bug_assignee_map[bugid] = assignee |
Member
There was a problem hiding this comment.
The bug_assignee_map dict does not seem to be used anywhere. Do we need it after the changes in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
to-be-announcedtag added if this is worth announcing