Conversation
| <script> | ||
| document.addEventListener('DOMContentLoaded', function () { |
There was a problem hiding this comment.
I do not think we could use js in emails.
There was a problem hiding this comment.
nope, we can't :)
but this doesn't matter much. I will export the html on a website
There was a problem hiding this comment.
We could make the bot export the HTML page. Some of the simple options could be a GCS bucket or GitHub pages (based on the same repo or a new repo). A subdomain could point to that page (e.g., reports.moz.tools).
We could also do the same for other rules so that the web pages will have the latest updated data.
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you, Sylvestre! Looks interesting! Could you please fix the formatting to make the CI happy?
| self.ndups = self.get_config("number_dups") | ||
| self.votes = self.get_config("number_votes") | ||
| self.cc = self.get_config("number_cc") | ||
| self.see_also = self.get_config("number_see_also") | ||
| self.comments = self.get_config("number_comments") |
There was a problem hiding this comment.
Could you please use the constructor parameters to configure the rules instead of the config file (see #1437)?
Alternatively, you could assign the values directly, just like the weights, without using the configuration file.
| self.ndups = self.get_config("number_dups") | ||
| self.votes = self.get_config("number_votes") | ||
| self.cc = self.get_config("number_cc") | ||
| self.see_also = self.get_config("number_see_also") | ||
| self.comments = self.get_config("number_comments") |
There was a problem hiding this comment.
We could unify the variable naming in a descriptive way (e.g., min_comments or num_comments_threshold)
| self.ndups = self.get_config("number_dups") | ||
| self.votes = self.get_config("number_votes") | ||
| self.cc = self.get_config("number_cc") | ||
| self.see_also = self.get_config("number_see_also") | ||
| self.comments = self.get_config("number_comments") |
There was a problem hiding this comment.
nit: It could be useful to add a comment to clarify that these thresholds are to highlight the values in the table, not to be used in the query.
| "f3": "OP", | ||
| "f4": "dupe_count", | ||
| "o4": "greaterthaneq", | ||
| "v4": "5", |
There was a problem hiding this comment.
nit: Declaring these thresholds in the constructor after the highlighting thresholds will help distinguish between the two types of thresholds.
2 participants
Can be seen here:
https://sylvestre.ledru.info/moz/bugscore.html