Conversation
Support zooming via touch pinch gestures (mobile) and trackpad/mouse wheel (desktop) through the existing onRequestScaleChange callback. Closes #368
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
react-avatar-editor | e1cf3f9 | Commit Preview URL Branch Preview URL |
Mar 31 2026, 07:04 AM |
Wheel/trackpad zoom is now disabled by default and gated behind the enableWheelZoom prop (default: false). Pinch-to-zoom with two fingers remains always enabled. Adds tests for both pinch and wheel zoom.
Remove jsdom-based unit tests for pinch/wheel zoom. Add Playwright screenshot tests that verify zoom visually: wheel scroll up/down, trackpad pinch (ctrlKey+wheel), and two-finger touch pinch via CDP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onRequestScaleChange)Closes #368
Test plan
pnpm test— 130 tests passing)