Sourcery Starbot ⭐ refactored haolly/dependency-resolver#1
Open
SourceryAI wants to merge 1 commit intomomadacoding:mainfrom
Open
Sourcery Starbot ⭐ refactored haolly/dependency-resolver#1SourceryAI wants to merge 1 commit intomomadacoding:mainfrom
SourceryAI wants to merge 1 commit intomomadacoding:mainfrom
Conversation
SourceryAI
commented
Jan 23, 2024
Comment on lines
-60
to
+63
| if not vtx in self.dummy_traversing_edges: | ||
| if vtx not in self.dummy_traversing_edges: | ||
| self.dummy_traversing_edges[vtx] = {} | ||
|
|
||
| if not child_vtx in self.dummy_traversing_edges[vtx]: | ||
| if child_vtx not in self.dummy_traversing_edges[vtx]: |
Author
There was a problem hiding this comment.
Function Layering.proper_layering refactored with the following changes:
- Simplify logical expression using De Morgan identities [×2] (
de-morgan)
Comment on lines
-75
to
+78
| resp = "" | ||
| for layer in self.__layers: | ||
| resp += str(layer.level) + " => " + str(layer.nodes) + "\n" | ||
| return resp | ||
| return "".join( | ||
| f"{str(layer.level)} => {str(layer.nodes)}" + "\n" | ||
| for layer in self.__layers | ||
| ) |
Author
There was a problem hiding this comment.
Function Layering.__str__ refactored with the following changes:
- Use str.join() instead of for loop (
use-join) - Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-129
to
+136
| fps = 0 | ||
| if self.dt: fps = 1/self.dt | ||
| fps = 1/self.dt if self.dt else 0 | ||
| if len(self.fps_list) == 50: | ||
| self.fps_list.pop(0) | ||
| self.fps_list.append(fps) | ||
| avg_fps = sum(self.fps_list) / len(self.fps_list) | ||
| pygame.display.set_caption('Dependency resolver - FPS: ' + str(round(avg_fps,2))) | ||
| pygame.display.set_caption( | ||
| f'Dependency resolver - FPS: {str(round(avg_fps, 2))}' | ||
| ) |
Author
There was a problem hiding this comment.
Function Resolver.get_fps refactored with the following changes:
- Move setting of default value for variable into
elsebranch (introduce-default-else) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-25
to
+32
| for i, ext in enumerate(self.SUPPORTED_FILES): | ||
| if filename.endswith(ext): | ||
| return i | ||
|
|
||
| return -1 | ||
| return next( | ||
| ( | ||
| i | ||
| for i, ext in enumerate(self.SUPPORTED_FILES) | ||
| if filename.endswith(ext) | ||
| ), | ||
| -1, | ||
| ) |
Author
There was a problem hiding this comment.
Function DependencyScanner.is_valid_project_file refactored with the following changes:
- Use the built-in function
nextinstead of a for-loop (use-next)
Comment on lines
-73
to
+84
|
|
||
| # Report progress to the caller | ||
| if self.__progress_cb: | ||
| self.__progress_cb(i, len(project_files), file.replace(path_dir, "")) | ||
|
|
||
| includes = self.get_includes(file) | ||
| dep_map[file] = includes | ||
| self.glob_log.info(f"Scan complete!") | ||
|
|
||
| self.glob_log.info("Scan complete!") |
Author
There was a problem hiding this comment.
Function DependencyScanner.scan_dir refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-136
to
+155
| if not u in self._adj_nodes[v]: | ||
| if u not in self._adj_nodes[v]: |
Author
There was a problem hiding this comment.
Function GraphAdjList.reverse_edge refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-53
to
+58
| target_project_dir = self.resolver.find_directory() | ||
|
|
||
| if target_project_dir: | ||
| if target_project_dir := self.resolver.find_directory(): | ||
| new_state = Scan(self.resolver, target_project_dir) | ||
| new_state.enter_state() | ||
| else: | ||
| self.resolver.show_error("Project directory", "You haven't selected a project directory.") | ||
|
|
Author
There was a problem hiding this comment.
Function Menu.update refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
|
|
||
| # prevent files with improper includes or "self includes" | ||
| if not included_file == source_file: | ||
| if included_file != source_file: |
Author
There was a problem hiding this comment.
Function Scan.__prepare_and_sort_dag refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
|
|
||
| if (node_id, vtx_out) in self.reversed_edges: | ||
| if not node_id in self.digraph.get_neighbors_out(vtx_out): | ||
| if node_id not in self.digraph.get_neighbors_out(vtx_out): |
Author
There was a problem hiding this comment.
Function World.render_nodes refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| self.state = ClickableState.HOVERED | ||
| if is_clicked: | ||
| self.state = ClickableState.CLICKED | ||
| self.state = ClickableState.CLICKED if is_clicked else ClickableState.HOVERED |
Author
There was a problem hiding this comment.
Function Button.update refactored with the following changes:
- Move setting of default value for variable into
elsebranch (introduce-default-else) - Replace if statement with if expression (
assign-if-exp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: