Skip to content

feat: handling mrpack with no loaders #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdgao wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: handling mrpack with no loaders #5363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
850d99c
handle modpack upload with no loaders
tdgao Feb 12, 2026
edd17d2
restrict loaders for modpack
tdgao Feb 12, 2026
0e62b05
actually, dont allow modpack loaders to be editable
tdgao Feb 12, 2026
452331b
revert loader picker changes
tdgao Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/frontend/src/components/ui/create-project-version/components/LoaderPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="flex flex-col gap-2.5">
<span class="font-semibold text-contrast">Loaders <span class="text-red">*</span></span>
<span class="font-semibold text-contrast">Loaders</span>

<Chips
v-model="loaderGroup"
Expand Down
8 changes: 7 additions & 1 deletion apps/frontend/src/components/ui/create-project-version/stages/MetadataStage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,13 @@
</TagItem>
</template>

<span v-if="!draftVersion.loaders.length">No loaders selected.</span>
<TagItem
v-if="!draftVersionLoaders.length && projectType === 'modpack'"
class="border !border-solid border-surface-5 hover:no-underline"
>
No mod loader
</TagItem>
<span v-else-if="!draftVersionLoaders.length">No loaders selected.</span>
</div>
</div>
</div>
Expand Down
4 changes: 0 additions & 4 deletions apps/frontend/src/providers/version/manage-version-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,6 @@ export function createManageVersionContext(
inferred.loaders = ['datapack']
}

if (noLoaders && projectType.value === 'modpack') {
inferred.loaders = ['minecraft']
}

inferredVersionData.value = inferred

return inferred
Expand Down
18 changes: 13 additions & 5 deletions apps/frontend/src/providers/version/stages/loaders-stage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ export const stageConfig: StageConfigInput<ManageVersionContextValue> = {
id: 'add-loaders',
stageContent: markRaw(LoadersStage),
title: (ctx) => (ctx.editingVersion.value ? 'Edit loaders' : 'Loaders'),
skip: (ctx) =>
(ctx.inferredVersionData.value?.loaders?.length ?? 0) > 0 || ctx.editingVersion.value,
skip: (ctx) => {
const inferredLoadersLength = ctx.inferredVersionData.value?.loaders?.length ?? 0
return (
inferredLoadersLength > 0 ||
ctx.editingVersion.value ||
(inferredLoadersLength === 0 && ctx.projectType.value === 'modpack')
)
},
hideStageInBreadcrumb: (ctx) => !ctx.primaryFile.value || ctx.handlingNewFiles.value,
cannotNavigateForward: (ctx) => ctx.draftVersion.value.loaders.length === 0,
leftButtonConfig: (ctx) => ({
Expand All @@ -36,20 +42,22 @@ export const fromDetailsStageConfig: StageConfigInput<ManageVersionContextValue>
leftButtonConfig: (ctx) => ({
label: 'Back',
icon: LeftArrowIcon,
disabled: ctx.draftVersion.value.loaders.length === 0,
disabled: ctx.draftVersion.value.loaders.length === 0 && ctx.projectType.value !== 'modpack',
onClick: () => ctx.modal.value?.setStage('metadata'),
}),
rightButtonConfig: (ctx) =>
ctx.editingVersion.value
? {
...ctx.saveButtonConfig(),
disabled: ctx.draftVersion.value.loaders.length === 0,
disabled:
ctx.draftVersion.value.loaders.length === 0 && ctx.projectType.value !== 'modpack',
}
: {
label: 'Add details',
icon: RightArrowIcon,
iconPosition: 'after',
disabled: ctx.draftVersion.value.loaders.length === 0,
disabled:
ctx.draftVersion.value.loaders.length === 0 && ctx.projectType.value !== 'modpack',
onClick: () => ctx.modal.value?.setStage('add-details'),
},
}