Skip to content

fix(model_splitter): multiple bug fixes#2728

Open
jlarsen-usgs wants to merge 4 commits intomodflowpy:developfrom
jlarsen-usgs:develop
Open

fix(model_splitter): multiple bug fixes#2728
jlarsen-usgs wants to merge 4 commits intomodflowpy:developfrom
jlarsen-usgs:develop

Conversation

@jlarsen-usgs
Copy link
Contributor

  • filter (-1,) SFR cellids from splitting mask creation in optimize_splitting_mask
  • adjust (-1,) SFR cellid layer number to 0 in _remap_sfr to avoid index errors
  • handle external model files by allowing user to specify new simulation workspace sim_ws to split_model and split_multi_model
  • dynamically adjust max_columns_of_data when external model files are maintained in the split models

Maintain external file paths when user passes optional sim_ws parameter
* filter (-1,) SFR cellids from splitting mask creation in optimize_splitting_mask
* adjust (-1,) SFR cellid layer number to 0 in _remap_sfr to avoid index errors
* handle external model files by allowing user to specify new simulation workspace `sim_ws` to `split_model` and `split_multi_model`
* dynamically adjust `max_columns_of_data` when external model files are maintained in the split models
@jlarsen-usgs
Copy link
Contributor Author

jlarsen-usgs commented Mar 6, 2026

@jptraylor

Closes #2726

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 47.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.4%. Comparing base (556c088) to head (29a6f49).
⚠️ Report is 138 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/utils/model_splitter.py 47.5% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2728      +/-   ##
===========================================
+ Coverage     55.5%    72.4%   +16.9%     
===========================================
  Files          644      674      +30     
  Lines       124135   130674    +6539     
===========================================
+ Hits         68947    94673   +25726     
+ Misses       55188    36001   -19187     
Files with missing lines Coverage Δ
flopy/mf6/utils/model_splitter.py 65.5% <47.5%> (-9.5%) ⬇️

... and 569 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant