fix(model_splitter): multiple bug fixes#2728
Open
jlarsen-usgs wants to merge 4 commits intomodflowpy:developfrom
Open
fix(model_splitter): multiple bug fixes#2728jlarsen-usgs wants to merge 4 commits intomodflowpy:developfrom
jlarsen-usgs wants to merge 4 commits intomodflowpy:developfrom
Conversation
Maintain external file paths when user passes optional sim_ws parameter
* filter (-1,) SFR cellids from splitting mask creation in optimize_splitting_mask * adjust (-1,) SFR cellid layer number to 0 in _remap_sfr to avoid index errors * handle external model files by allowing user to specify new simulation workspace `sim_ws` to `split_model` and `split_multi_model` * dynamically adjust `max_columns_of_data` when external model files are maintained in the split models
Contributor
Author
|
Closes #2726 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2728 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.9%
===========================================
Files 644 674 +30
Lines 124135 130674 +6539
===========================================
+ Hits 68947 94673 +25726
+ Misses 55188 36001 -19187
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim_wstosplit_modelandsplit_multi_modelmax_columns_of_datawhen external model files are maintained in the split models