Skip to content

fix: Remove logging initialization from MCPServer.__init__ #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonZehetner wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −28
Open

fix: Remove logging initialization from MCPServer.__init__ #2004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/mcp/server/mcpserver/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from mcp.server.mcpserver.resources import FunctionResource, Resource, ResourceManager
from mcp.server.mcpserver.tools import Tool, ToolManager
from mcp.server.mcpserver.utilities.context_injection import find_context_parameter
from mcp.server.mcpserver.utilities.logging import configure_logging, get_logger
from mcp.server.mcpserver.utilities.logging import get_logger
from mcp.server.sse import SseServerTransport
from mcp.server.stdio import stdio_server
from mcp.server.streamable_http import EventStore
Expand Down Expand Up @@ -167,9 +167,6 @@ def __init__(
# Set up MCP protocol handlers
self._setup_handlers()

# Configure logging
configure_logging(self.settings.log_level)

@property
def name(self) -> str:
return self._lowlevel_server.name
Expand Down
24 changes: 0 additions & 24 deletions src/mcp/server/mcpserver/utilities/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Logging utilities for MCPServer."""

import logging
from typing import Literal


def get_logger(name: str) -> logging.Logger:
Expand All @@ -14,26 +13,3 @@ def get_logger(name: str) -> logging.Logger:
a configured logger instance
"""
return logging.getLogger(name)


def configure_logging(
level: Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] = "INFO",
) -> None:
"""Configure logging for MCP.

Args:
level: the log level to use
"""
handlers: list[logging.Handler] = []
try:
from rich.console import Console
from rich.logging import RichHandler

handlers.append(RichHandler(console=Console(stderr=True), rich_tracebacks=True))
except ImportError: # pragma: no cover
pass

if not handlers: # pragma: no cover
handlers.append(logging.StreamHandler())

logging.basicConfig(level=level, format="%(message)s", handlers=handlers)
Loading