callServerTool: opt into progress-based timeout reset#600
Open
anthroy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
callServerTool: opt into progress-based timeout reset#600anthroy wants to merge 1 commit intomodelcontextprotocol:mainfrom
anthroy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Hosts may interpose long-running steps (e.g. inline OAuth on 401) between the guest's tools/call and the server's response. Without this, the base SDK's 60s DEFAULT_REQUEST_TIMEOUT_MSEC fires and the guest sees -32001 even though the host is still working. Passing onprogress causes Protocol.request to include _meta.progressToken in the outgoing request and register a progress handler; resetTimeoutOnProgress makes incoming notifications/progress reset the per-request timer. Hosts can then heartbeat during human-in-the-loop steps. Callers can still override both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A host may interpose a long-running, human-in-the-loop step between the guest's
tools/calland the server's response. During that wait, the base SDK'sDEFAULT_REQUEST_TIMEOUT_MSEC(60s) inProtocol.request()fires and the guest surfaces-32001 Request timed out, even though the host is still working and will eventually deliver the result.Change
callServerToolnow defaultsonprogressto a no-op andresetTimeoutOnProgresstotrue. This causesProtocol.requestto:_meta.progressTokenin the outgoing requestnotifications/progressarrives for that tokenHosts can then heartbeat (
notifications/progress) during long-running interposed steps to keep the request alive. Tool calls are the request type expected to be long-running, so this is the right layer to opt in. Callers can still override both options.No behavior change for hosts that don't send progress — the no-op handler just makes the SDK able to receive heartbeats.