Implement reading .CMT comment files in our Nihon Kohden reader#13642
Draft
wmvanvliet wants to merge 4 commits intomne-tools:mainfrom
Draft
Implement reading .CMT comment files in our Nihon Kohden reader#13642wmvanvliet wants to merge 4 commits intomne-tools:mainfrom
wmvanvliet wants to merge 4 commits intomne-tools:mainfrom
Conversation
wmvanvliet
requested review from
agramfort,
drammock,
larsoner and
mscheltienne
as code owners
wmvanvliet
force-pushed
the
nihon-comments
branch
from
be3243f to
66cfa2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements basic support for reading the
.CMTsidecar file in Nihon Kohden EEG recordings. These comment are an extension to the annotations functionality, where the annotation description isP_COMMENTand should be replaced with the corresponding comment in the.CMTfile. Comments can include images and have markup such as background and foreground colors. We ignore all that and just replace theP_COMMENTstring in the annotation with the text of the comment.Fixes #13633.
Todo: