Fix external domain dropdown defaulting to alphabetically first instead of site-default domain#247
Open
Fix external domain dropdown defaulting to alphabetically first instead of site-default domain#247
Conversation
Co-authored-by: runleveldev <44057501+runleveldev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sorting of external domains for HTTP services
Fix external domain dropdown defaulting to alphabetically first instead of site-default domain
Mar 19, 2026
runleveldev
requested changes
Mar 19, 2026
…ains() Co-authored-by: runleveldev <44057501+runleveldev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating/editing a container with an HTTP service, the domain dropdown was sorted alphabetically by name, causing a non-default domain to be auto-selected instead of the site's default domain.
Changes
routers/containers.js: ReplacedORDER BY name ASCwith a partitioned sort — site-default domains (wheresiteIdmatches the current site) come first ordered byid, followed by all others ordered byid.sortExternalDomains(domains, siteId)helper to encapsulate the single-pass partition, used by both thenewandeditcontainer routes.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.