Skip to content

feat: add manager ready timeout setting (experimental)#1308

Open
eleanorjboyd wants to merge 1 commit intomicrosoft:mainfrom
eleanorjboyd:general-mite
Open

feat: add manager ready timeout setting (experimental)#1308
eleanorjboyd wants to merge 1 commit intomicrosoft:mainfrom
eleanorjboyd:general-mite

Conversation

@eleanorjboyd
Copy link
Member

add experimental setting allowing the user to control how long the manager timeout is (ie how long to wait for managers to register or attempt to register environments they discover)

@eleanorjboyd eleanorjboyd self-assigned this Mar 3, 2026
@eleanorjboyd eleanorjboyd added the feature-request Request for new features or functionality label Mar 3, 2026
@eleanorjboyd eleanorjboyd requested review from Copilot and karthiknadig and removed request for Copilot March 3, 2026 05:38
@vs-code-engineering vs-code-engineering bot added this to the March 2026 milestone Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an experimental configuration setting to control how long the extension waits for environment/package managers to register before timing out, improving behavior on slower systems (e.g., remote or network filesystems).

Changes:

  • Introduces python-envs.experimental.managerReadyTimeout (seconds) with a 5–120s allowed range.
  • Updates manager registration wait logic to use the configured timeout value and logs the effective value on timeout.
  • Adds corresponding configuration metadata and localized setting description.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/features/common/managerReady.ts Reads the new setting and uses it to compute the timeout applied to manager readiness waits.
package.json Contributes the new experimental setting with schema validation (default/min/max, machine scope).
package.nls.json Adds the localized description string used by the new setting.

@joaomorenoalt joaomorenoalt removed this from the March 2026 milestone Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants