feat: add manager ready timeout setting (experimental)#1308
Open
eleanorjboyd wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: add manager ready timeout setting (experimental)#1308eleanorjboyd wants to merge 1 commit intomicrosoft:mainfrom
eleanorjboyd wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an experimental configuration setting to control how long the extension waits for environment/package managers to register before timing out, improving behavior on slower systems (e.g., remote or network filesystems).
Changes:
- Introduces
python-envs.experimental.managerReadyTimeout(seconds) with a 5–120s allowed range. - Updates manager registration wait logic to use the configured timeout value and logs the effective value on timeout.
- Adds corresponding configuration metadata and localized setting description.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/features/common/managerReady.ts | Reads the new setting and uses it to compute the timeout applied to manager readiness waits. |
| package.json | Contributes the new experimental setting with schema validation (default/min/max, machine scope). |
| package.nls.json | Adds the localized description string used by the new setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add experimental setting allowing the user to control how long the manager timeout is (ie how long to wait for managers to register or attempt to register environments they discover)