[rush] Add support for rush-sdk to be webpacked.#3208
Merged
iclanton merged 6 commits intomicrosoft:masterfrom Feb 6, 2022
Merged
[rush] Add support for rush-sdk to be webpacked.#3208iclanton merged 6 commits intomicrosoft:masterfrom
iclanton merged 6 commits intomicrosoft:masterfrom
Conversation
iclanton
requested review from
D4N14L,
apostolisms,
octogonz and
sachinjoseph
as code owners
Collaborator
octogonz
reviewed
Feb 5, 2022
octogonz
reviewed
Feb 5, 2022
octogonz
approved these changes
Feb 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
rush-sdkcan't be used in a project that has been bundled with Webpack.Details
This PR replaces instances of
require()inrush-sdkwith a call to a function that detects if we're executing inside a webpack bundle and calls a Webpack macro function that maps to the realrequirefunction instead of the built-in Webpack require (which errors in this case).How it was tested
Tested by bundling a small tool that uses
rush-libviarush-sdkwith Webpack 5 and executing the bundle.