Add 'resolveImageSource' option to support cid image source for canvas editing#3301
Open
liangdrime wants to merge 3 commits intomicrosoft:masterfrom
Open
Add 'resolveImageSource' option to support cid image source for canvas editing#3301liangdrime wants to merge 3 commits intomicrosoft:masterfrom
liangdrime wants to merge 3 commits intomicrosoft:masterfrom
Conversation
added 2 commits
March 6, 2026 17:16
JiuqingSong
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix image editing for content-model scenarios where image
srcusescid:protocol by introducing a newresolveImageSourceoption.This allows clients to convert
cid:URLs to canvas-safe URLs (such as base64 data URLs) before edit operations run.Background
On the Outlook for iOS/Mac, images are stored as
cid:URLs.Canvas APIs cannot draw
cid:images directly, so editing features that depend on canvas regeneration fail.Before content model, the client could override
setEditingImageto convertcid:to base64 before editing.In content model flow, relying on this approach to override some interface is not reliable.
What changed
resolveImageSource?: (src: string) => string | undefinedtoImageEditOptions.resolveImageSourceintoImageEditPlugin.canRegenerateImage(...).canRegenerateImage(...)utility to recognize resolvable image sources as regeneratable.createImageWrapper(...)so editing uses resolved, canvas-safesrc.Example usage