fix: prevent AttributeError in joblib worker config sync#2111
Open
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: prevent AttributeError in joblib worker config sync#2111Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
) In joblib worker processes, `register_from_C` can crash with `AttributeError: No such registered in self._config` when the worker's fresh Config instance hasn't fully initialized `_registered`. Use `getattr(C, "registered", False)` to safely default to False when the attribute is missing, allowing the worker to proceed with config synchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2038
When backtests spawn joblib worker processes,
register_from_Ccan crash with:This happens because the worker's fresh
Configinstance may not have the_registeredkey available whenC.registeredis accessed.Fix
Replace the direct attribute access with a safe
getattrcall:This defaults to
Falsewhen the attribute is missing, allowing the worker to proceed with config synchronization from the main process.Test Plan
registeredattribute existsFalse