Draft
Conversation
joao-boechat
requested review from
billti,
idavis and
minestarks
as code owners
| // stopOnEntry is set to false when the user runs the program with debugging. | ||
| // unless overridden. | ||
| config.stopOnEntry = config.stopOnEntry ?? !config.noDebug; | ||
| config.stopOnEntry = config.stopOnEntry ?? false; |
Contributor
There was a problem hiding this comment.
Should this config.stopOnEntry be removed as a config field if it should always be false?
Contributor
Author
There was a problem hiding this comment.
We still want to give the users the option to choose that, so if they define it on launch.json as being true it should behave that way
joao-boechat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue 2646 by changing the default behavior of qdk debugger, so that it won't stop on entry.