fix(config): throw on workers=0 or negative value#39992
Closed
bwyard wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(config): throw on workers=0 or negative value#39992bwyard wants to merge 1 commit intomicrosoft:mainfrom
bwyard wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- --workers=0 and --workers=-1 via CLI bypassed validation and resolved silently, causing an empty test run that exits 0 - resolveWorkers only guarded against NaN, not <= 0 - config-file path already throws (configLoader.ts:325) but CLI override path did not Fixes microsoft#39938
Contributor
Author
|
Perfect I need to double check my employment contract today/tomorrow as I am an employed sdet so I'll have one of the two done tomorrow. I know I have permission to contribute but can't remember if my contract gives them ownership or not. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
there's already an open PR about this here, btw: #39940 |
Contributor
Author
|
Oh dang I didn't see the pr attached to the issue but that's fair can go ahead and close then my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39938