igvm_defs, igvm: introduce corim measurement header#99
Open
chris-oo wants to merge 10 commits intomicrosoft:mainfrom
Open
igvm_defs, igvm: introduce corim measurement header#99chris-oo wants to merge 10 commits intomicrosoft:mainfrom
chris-oo wants to merge 10 commits intomicrosoft:mainfrom
Conversation
ionut-arm
reviewed
Nov 14, 2025
igvm_defs/src/lib.rs
Outdated
| /// A structure defining a CoRIM CBOR payload for a given platform. TODO: rename | ||
| /// to remove measurement? | ||
| /// | ||
| /// The payload described by this header is a CBOR CoRIM payload. There may only |
There was a problem hiding this comment.
Would be good to be have a similar level of detail here as below, pointing to section 4.1 of the spec, and explicitly calling it out as a tagged unsigned CoRIM map.
Member
Author
There was a problem hiding this comment.
How does the verbage look on the most recent iteration?
|
CoRIM spec does not seem to support detached mode —- waiting for confirmation ietf-rats-wg/draft-ietf-rats-corim#514 |
|
There is a proposal to add detached mode support: ietf-rats-wg/draft-ietf-rats-corim#520 |
mingweishih
reviewed
Jan 8, 2026
mingweishih
reviewed
Jan 8, 2026
mingweishih
reviewed
Jan 8, 2026
mingweishih
reviewed
Jan 8, 2026
mingweishih
reviewed
Jan 8, 2026
mingweishih
reviewed
Jan 8, 2026
chris-oo
force-pushed
the
corim-header
branch
from
208a082 to
925441f
Compare
msft-jlange
reviewed
Feb 25, 2026
igvm_defs/src/lib.rs
Outdated
Comment on lines
+1261
to
+1263
| /// | VBS | TBD | | ||
| /// | AMD SEV-SNP | TBD | | ||
| /// | ARM CCA | TBD | |
Contributor
There was a problem hiding this comment.
This table doesn't appear to line up correctly.
Member
Author
There was a problem hiding this comment.
let me see if i can mess with it, but it does render correctly in the markdown/docs.rs view.
msft-jlange
reviewed
Feb 25, 2026
mingweishih
reviewed
Mar 21, 2026
chris-oo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a CoRIM document and CoRIM signature header to allow CoRIM payloads to be described for a given platform. This is the bare-minimum support to start proving out CoRIM support for IGVM files, with more support tracked by #115.