Add msgo/modulehash telemetry counter#2186
Draft
gdams wants to merge 2 commits intomicrosoft/mainfrom
Draft
Conversation
Emit a SHA-256 hash of the main module path as a numeric telemetry counter during build, install, and run commands. The module path is hashed to avoid transmitting potentially sensitive names. Re-vendor go-infra telemetry to pick up wildcard prefix support in the upload filter.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Microsoft-specific telemetry counter (msgo/modulehash:*) derived from the main module path and updates the vendored go-infra/telemetry dependency to support wildcard-prefix counter filtering during upload.
Changes:
- Emit
msgo/modulehash:<sha256-as-decimal>viacmd/go/internal/telemetrystatsby hashing the module path fromgo.mod. - Update the vendored
github.com/microsoft/go-infra/telemetryversion and extend upload filtering to support wildcard counter prefixes (e.g.msgo/modulehash:*).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| patches/0009-Add-appinsights-telemetry.patch | Adds the msgo/modulehash counter emission to telemetrystats. |
| patches/0001-Vendor-external-dependencies.patch | Re-vendors go-infra/telemetry, adds wildcard-prefix support for upload filtering, and updates the upload config to include msgo/modulehash:*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a SHA-256 hash of the main module path as a numeric telemetry counter during build, install, and run commands.
Re-vendor go-infra telemetry to pick up wildcard prefix support in the upload filter.