fix (socat): skip %check — flaky proxy tests fail in mock#16221
Open
liunan-ms wants to merge 3 commits intotomls/base/mainfrom
Open
fix (socat): skip %check — flaky proxy tests fail in mock#16221liunan-ms wants to merge 3 commits intotomls/base/mainfrom
liunan-ms wants to merge 3 commits intotomls/base/mainfrom
Conversation
liunan-ms
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the socat component’s %check phase to avoid mock build failures, replacing prior targeted %check overlays with a single build-level skip directive.
Changes:
- Removed two
%check-section overlays (SHELL export and VSOCK test exclusion). - Added
build.check.skip = truewith askip_reasonforsocat.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ddstreetmicrosoft
requested changes
Mar 18, 2026
Contributor
ddstreetmicrosoft
left a comment
ddstreetmicrosoft
left a comment
There was a problem hiding this comment.
please rebase into a single commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the configuration for the
socatcomponent by disabling its test suite due to flaky tests, replacing previous overlay-based workarounds with a single skip directive.Validated by koji build: https://52.249.25.247/koji/taskinfo?taskID=632464