Skip to content

fix: ntpdate-wrapper binary path#16210

Open
realsdx wants to merge 1 commit into3.0-devfrom
sudipta/update-ntpdate-wrapper
Open

fix: ntpdate-wrapper binary path#16210
realsdx wants to merge 1 commit into3.0-devfrom
sudipta/update-ntpdate-wrapper

Conversation

@realsdx
Copy link
Contributor

@realsdx realsdx commented Mar 17, 2026

The ntp package installs ntpdate at /usr/bin/ntpdate, but ntpdate-wrapper still hardcodes /usr/sbin/ntpdate.

Update the wrapper to use /usr/bin/ntpdate so it matches the packaged file layout.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
The ntp RPM installs ntpdate at /usr/bin/ntpdate, but
ntpdate-wrapper still references /usr/sbin/ntpdate.

This causes /usr/libexec/ntpdate-wrapper to fail immediately on Azure Linux 3.0
before invoking ntpdate.

On Azl3 wrapper fails

$ sudo test -x /usr/sbin/ntpdate; echo $?
1
$ sudo test -x /usr/bin/ntpdate; echo $?
0
$ sudo bash -x /usr/libexec/ntpdate-wrapper
+ ntpconf=/etc/ntp.conf
+ ntpstep=/etc/ntp/step-tickers
+ '[' 0 '!=' 0 ']'
+ '[' -x /usr/sbin/ntpdate ']'
+ exit 5
Change Log
  • fix ntpdate-wrapper to use /usr/bin/ntpdate
Work Item
Does this affect the toolchain?

NO

Test Methodology

The ntp package installs ntpdate at /usr/bin/ntpdate, but
ntpdate-wrapper still hardcodes /usr/sbin/ntpdate.

Update the wrapper to use /usr/bin/ntpdate so it matches the
packaged file layout.
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Mar 17, 2026
@realsdx
Copy link
Contributor Author

realsdx commented Mar 17, 2026

Note: Current spec check failure is related to #16172

@realsdx realsdx marked this pull request as ready for review March 17, 2026 12:26
@realsdx realsdx requested a review from a team as a code owner March 17, 2026 12:26
Copy link
Contributor

@Sumynwa Sumynwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@realsdx realsdx added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants