Add job result tests for output with dash#718
Open
rigidit wants to merge 2 commits intomicrosoft:mainfrom
Open
Add job result tests for output with dash#718rigidit wants to merge 2 commits intomicrosoft:mainfrom
rigidit wants to merge 2 commits intomicrosoft:mainfrom
Conversation
xinyi-joffre
approved these changes
Feb 10, 2026
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to start returning "-" instead of "2" for atom loss in job outputs, so added tests to check that dash support.
General job.py here handles string "as is". The Cirq's job just uses general job's get_results that supports a dash, but Qiskit's job is translating Microsoft's results histograms into a Qiskit format and it fails with syntax error here when there is a dash, so this is also covered with new unit test in this PR.