Add Windows ARM64 and x86 platform support to install scripts#652
Add Windows ARM64 and x86 platform support to install scripts#652
Conversation
| $osArch = "-x86" | ||
| } | ||
| else { | ||
| return "" |
There was a problem hiding this comment.
do we need to write the warning here too ?
There was a problem hiding this comment.
IMO it isn't necessary in either, but i'll add it for parity.
If I was a linux x86 user and I saw a message about windows x86, I would think it's a bit odd to see messaging related to a separate platform and their supported infra.
There was a problem hiding this comment.
would a continue be better than returning empty and that way the default warning is used instead
There was a problem hiding this comment.
here and in the sh file as well if theres an equivalent
There was a problem hiding this comment.
Neither powershell nor bash have a clean way to enter the default case inside a switch statement. I think what we have in the PR is the cleanest way to get the behavior we want
2 participants
installcredprovider.ps1x86architecture mapping to the switch block inGet-RuntimeIdentifierwin-arm64 -> win-x64remap that forced ARM64 Windows onto the x64 binaryinstallcredprovider.shi386 | i686 | x86architecture case toset_runtime_identifierwin-arm64 -> win-x64remap that previously forced ARM64 Windows onto the x64 binaryNotes
These script changes are a prerequisite for the upcoming release that will include
win-arm64andwin-x86build artifacts. The install scripts will work end-to-end once those assets are published.