Use numeric literals for BYTES_PER_ELEMENT by lionel-rowe · Pull Request #59567 · microsoft/TypeScript

lionel-rowe · 2024-08-09T02:27:37Z

jakebailey · 2024-08-09T03:14:07Z

typescript-bot · 2024-08-09T03:14:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-09T03:34:33Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-09T03:43:46Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59567/merge:

Everything looks good!

typescript-bot · 2024-08-09T03:50:43Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,532k (± 0.96%)}	_{192,393k (± 0.08%)}	_~	_192,308k	_192,678k	_{p=0.810 n=6}
_{Parse Time}	_{1.30s (± 1.23%)}	_{1.31s (± 0.62%)}	_~	_1.30s	_1.32s	_{p=0.498 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.54s (± 0.47%)}	_{9.53s (± 0.23%)}	_~	_9.50s	_9.56s	_{p=0.375 n=6}
_{Emit Time}	_{2.73s (± 1.28%)}	_{2.73s (± 0.60%)}	_~	_2.71s	_2.75s	_{p=0.627 n=6}
_{Total Time}	_{14.29s (± 0.44%)}	_{14.27s (± 0.19%)}	_~	_14.23s	_14.30s	_{p=0.809 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,300	_{-457 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,045	_409,844	_{-201 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,535k (± 0.00%)}	_{1,222,029k (± 0.00%)}	_{-507k (- 0.04%)}	_1,221,994k	_1,222,063k	_{p=0.005 n=6}
_{Parse Time}	_{6.64s (± 0.30%)}	_{6.62s (± 0.65%)}	_~	_6.56s	_6.67s	_{p=0.289 n=6}
_{Bind Time}	_1.86s	_{1.86s (± 0.53%)}	_~	_1.85s	_1.88s	_{p=1.000 n=6}
_{Check Time}	_{31.04s (± 0.30%)}	_{31.25s (± 0.37%)}	_{+0.21s (+ 0.69%)}	_31.12s	_31.43s	_{p=0.016 n=6}
_{Emit Time}	_{14.99s (± 0.34%)}	_{14.92s (± 0.74%)}	_~	_14.70s	_15.00s	_{p=0.227 n=6}
_{Total Time}	_{54.53s (± 0.23%)}	_{54.66s (± 0.33%)}	_~	_54.34s	_54.83s	_{p=0.127 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,487,631	_2,487,631	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,012,953	_1,012,953	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,493,513k (± 0.00%)}	_{2,493,517k (± 0.00%)}	_~	_2,493,475k	_2,493,574k	_{p=0.748 n=6}
_{Parse Time}	_{9.26s (± 0.41%)}	_{9.26s (± 0.39%)}	_~	_9.21s	_9.30s	_{p=0.746 n=6}
_{Bind Time}	_{2.18s (± 0.82%)}	_{2.18s (± 0.55%)}	_~	_2.16s	_2.19s	_{p=0.559 n=6}
_{Check Time}	_{75.97s (± 0.60%)}	_{76.03s (± 0.29%)}	_~	_75.73s	_76.41s	_{p=0.470 n=6}
_{Emit Time}	_{0.28s (± 3.53%)}	_{0.28s (± 2.95%)}	_~	_0.27s	_0.29s	_{p=0.862 n=6}
_{Total Time}	_{87.69s (± 0.56%)}	_{87.75s (± 0.28%)}	_~	_87.40s	_88.14s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,229,498	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,061	_263,938	_{-123 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,349,119k (± 0.03%)}	_{2,349,325k (± 0.03%)}	_~	_2,348,980k	_2,350,554k	_{p=0.128 n=6}
_{Parse Time}	_{5.97s (± 0.62%)}	_{6.01s (± 0.77%)}	_~	_5.96s	_6.08s	_{p=0.127 n=6}
_{Bind Time}	_{2.23s (± 0.96%)}	_{2.23s (± 0.46%)}	_~	_2.21s	_2.24s	_{p=0.872 n=6}
_{Check Time}	_{40.64s (± 0.38%)}	_{40.61s (± 0.38%)}	_~	_40.37s	_40.81s	_{p=0.689 n=6}
_{Emit Time}	_{4.04s (± 3.82%)}	_{3.93s (± 0.96%)}	_~	_3.89s	_4.00s	_{p=0.093 n=6}
_{Total Time}	_{52.88s (± 0.44%)}	_{52.81s (± 0.26%)}	_~	_52.58s	_52.96s	_{p=0.630 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,498	_1,229,498	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,061	_263,938	_{-123 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,423,198k (± 0.02%)}	_{2,422,892k (± 0.02%)}	_~	_2,422,196k	_2,423,459k	_{p=0.378 n=6}
_{Parse Time}	_{5.13s (± 0.76%)}	_{5.14s (± 0.31%)}	_~	_5.11s	_5.15s	_{p=0.687 n=6}
_{Bind Time}	_{1.68s (± 0.73%)}	_{1.69s (± 0.53%)}	_~	_1.68s	_1.70s	_{p=0.445 n=6}
_{Check Time}	_{34.97s (± 0.22%)}	_{35.06s (± 0.24%)}	_~	_34.98s	_35.17s	_{p=0.229 n=6}
_{Emit Time}	_{3.33s (± 0.65%)}	_{3.35s (± 0.51%)}	_~	_3.33s	_3.38s	_{p=0.570 n=6}
_{Total Time}	_{45.13s (± 0.22%)}	_{45.23s (± 0.20%)}	_~	_45.14s	_45.35s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,739	_256,739	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,560	_105,515	_{-45 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,989k (± 0.07%)}	_{429,034k (± 0.05%)}	_~	_428,853k	_429,323k	_{p=0.423 n=6}
_{Parse Time}	_{3.37s (± 1.02%)}	_{3.38s (± 0.52%)}	_~	_3.36s	_3.41s	_{p=0.568 n=6}
_{Bind Time}	_{1.31s (± 1.40%)}	_{1.32s (± 0.93%)}	_~	_1.30s	_1.33s	_{p=0.931 n=6}
_{Check Time}	_{18.05s (± 0.13%)}	_{18.12s (± 0.45%)}	_~	_18.00s	_18.21s	_{p=0.102 n=6}
_{Emit Time}	_{1.65s (± 0.92%)}	_{1.64s (± 1.14%)}	_~	_1.63s	_1.68s	_{p=0.743 n=6}
_{Total Time}	_{24.38s (± 0.27%)}	_{24.46s (± 0.39%)}	_~	_24.30s	_24.56s	_{p=0.172 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,139k (± 0.03%)}	_{370,139k (± 0.03%)}	_~	_370,036k	_370,359k	_{p=0.810 n=6}
_{Parse Time}	_{2.75s (± 1.03%)}	_{2.75s (± 0.76%)}	_~	_2.73s	_2.78s	_{p=1.000 n=6}
_{Bind Time}	_{1.57s (± 0.94%)}	_{1.56s (± 0.75%)}	_~	_1.54s	_1.57s	_{p=0.142 n=6}
_{Check Time}	_{15.63s (± 0.33%)}	_{15.64s (± 0.48%)}	_~	_15.55s	_15.76s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.96s (± 0.37%)}	_{19.96s (± 0.37%)}	_~	_19.89s	_20.09s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,995,060	_2,994,993	_{-67 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,032,052	_1,031,981	_{-71 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,120,580k (± 0.00%)}	_{3,120,352k (± 0.00%)}	_{-228k (- 0.01%)}	_3,120,278k	_3,120,418k	_{p=0.005 n=6}
_{Parse Time}	_{13.84s (± 0.15%)}	_{13.84s (± 0.38%)}	_~	_13.80s	_13.94s	_{p=0.468 n=6}
_{Bind Time}	_{4.29s (± 0.54%)}	_{4.29s (± 0.28%)}	_~	_4.28s	_4.31s	_{p=0.934 n=6}
_{Check Time}	_{79.68s (± 0.57%)}	_{79.47s (± 0.44%)}	_~	_79.05s	_79.88s	_{p=0.378 n=6}
_{Emit Time}	_{20.44s (± 0.47%)}	_{20.41s (± 0.74%)}	_~	_20.23s	_20.60s	_{p=0.810 n=6}
_{Total Time}	_{118.25s (± 0.43%)}	_{118.02s (± 0.41%)}	_~	_117.42s	_118.57s	_{p=0.470 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_273,789	_273,720	_{-69 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_111,669	_111,617	_{-52 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{419,907k (± 0.01%)}	_{419,705k (± 0.01%)}	_{-202k (- 0.05%)}	_419,623k	_419,785k	_{p=0.005 n=6}
_{Parse Time}	_{3.97s (± 0.58%)}	_{3.96s (± 0.37%)}	_~	_3.94s	_3.98s	_{p=0.330 n=6}
_{Bind Time}	_{1.73s (± 0.94%)}	_{1.73s (± 0.89%)}	_~	_1.71s	_1.75s	_{p=0.743 n=6}
_{Check Time}	_{17.04s (± 0.22%)}	_{17.04s (± 0.50%)}	_~	_16.93s	_17.17s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.73s (± 0.16%)}	_{22.73s (± 0.39%)}	_~	_22.60s	_22.83s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,614	_538,614	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,536	_176,536	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,533k (± 0.02%)}	_{481,464k (± 0.00%)}	_~	_481,440k	_481,482k	_{p=0.065 n=6}
_{Parse Time}	_{4.26s (± 0.79%)}	_{4.24s (± 0.42%)}	_~	_4.21s	_4.26s	_{p=0.571 n=6}
_{Bind Time}	_{1.55s (± 1.20%)}	_{1.54s (± 0.68%)}	_~	_1.53s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{22.36s (± 0.30%)}	_{22.34s (± 0.27%)}	_~	_22.27s	_22.41s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.17s (± 0.24%)}	_{28.13s (± 0.19%)}	_~	_28.06s	_28.20s	_{p=0.335 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-09T04:58:35Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59567/merge:

Everything looks good!

Copilot

Pull request overview

This PR changes the BYTES_PER_ELEMENT property type from number to specific numeric literal types (1, 2, 4, 8) for all TypedArray types. This enables better type narrowing and allows developers to use BYTES_PER_ELEMENT values in contexts expecting specific numeric literal unions.

Changes:

Updated TypedArray interface definitions in library files to use numeric literal types instead of number for BYTES_PER_ELEMENT
Updated test baselines to reflect the new, more precise error messages that now reference BYTES_PER_ELEMENT incompatibility instead of Symbol.toStringTag incompatibility

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/lib/es5.d.ts	Updated BYTES_PER_ELEMENT to numeric literals (1, 2, 4, 8) for Int8Array, Uint8Array, Uint8ClampedArray, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, and Float64Array
src/lib/es2020.bigint.d.ts	Updated BYTES_PER_ELEMENT to literal 8 for BigInt64Array and BigUint64Array
src/lib/esnext.float16.d.ts	Updated BYTES_PER_ELEMENT to literal 2 for Float16Array
tests/baselines/reference/typedArraysCrossAssignability01.errors.txt	Updated error messages to reflect BYTES_PER_ELEMENT incompatibility instead of Symbol.toStringTag
tests/baselines/reference/sharedMemory.types	Updated type annotations to show specific numeric literals for BYTES_PER_ELEMENT
tests/baselines/reference/es2024SharedMemory.types	Updated type annotations to show specific numeric literals for BYTES_PER_ELEMENT

tests/baselines/reference/typedArraysCrossAssignability01.errors.txt

jakebailey · 2026-02-06T06:08:56Z

@typescript-bot test it

typescript-bot · 2026-02-06T06:09:02Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2026-02-06T06:30:30Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2026-02-06T06:38:19Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59567/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2026-02-06T07:06:47Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_82,521	_82,521	_~	_~	_~	_{p=1.000 n=6}
_Types	_125,280	_125,280	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{275,528k (± 0.66%)}	_{275,553k (± 0.65%)}	_~	_274,324k	_277,888k	_{p=0.689 n=6}
_{Parse Time}	_{1.29s (± 0.65%)}	_{1.30s (± 0.75%)}	_~	_1.29s	_1.31s	_{p=0.256 n=6}
_{Bind Time}	_{0.75s (± 0.54%)}	_{0.76s (± 0.72%)}	_~	_0.75s	_0.76s	_{p=0.282 n=6}
_{Check Time}	_{14.10s (± 0.40%)}	_{14.09s (± 0.59%)}	_~	_14.03s	_14.25s	_{p=0.573 n=6}
_{Emit Time}	_{2.62s (± 0.37%)}	_{2.65s (± 0.85%)}	_~	_2.61s	_2.67s	_{p=0.072 n=6}
_{Total Time}	_{18.77s (± 0.30%)}	_{18.80s (± 0.55%)}	_~	_18.70s	_18.99s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,823	_955,928	_{+105 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_415,853	_415,912	_{+59 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,254,753k (± 0.00%)}	_{1,254,899k (± 0.01%)}	_{+146k (+ 0.01%)}	_1,254,802k	_1,255,051k	_{p=0.020 n=6}
_{Parse Time}	_{6.58s (± 0.49%)}	_{6.58s (± 0.76%)}	_~	_6.50s	_6.64s	_{p=0.810 n=6}
_{Bind Time}	_{1.97s (± 0.38%)}	_{1.97s (± 0.21%)}	_~	_1.96s	_1.97s	_{p=0.389 n=6}
_{Check Time}	_{32.46s (± 0.23%)}	_{32.51s (± 0.28%)}	_~	_32.37s	_32.63s	_{p=0.173 n=6}
_{Emit Time}	_{15.02s (± 0.38%)}	_{14.93s (± 0.32%)}	_{-0.09s (- 0.57%)}	_14.86s	_14.99s	_{p=0.030 n=6}
_{Total Time}	_{56.03s (± 0.25%)}	_{56.00s (± 0.11%)}	_~	_55.92s	_56.10s	_{p=0.335 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	_11,439	_11,439	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,703,113	_2,703,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_931,060	_931,060	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,039,018k (± 0.00%)}	_{3,039,088k (± 0.00%)}	_{+71k (+ 0.00%)}	_3,039,020k	_3,039,164k	_{p=0.045 n=6}
_{Parse Time}	_{8.51s (± 0.14%)}	_{8.52s (± 0.19%)}	_~	_8.51s	_8.55s	_{p=0.458 n=6}
_{Bind Time}	_{2.30s (± 0.71%)}	_{2.31s (± 0.36%)}	_~	_2.29s	_2.31s	_{p=0.753 n=6}
_{Check Time}	_{92.96s (± 0.43%)}	_{92.93s (± 0.33%)}	_~	_92.49s	_93.32s	_{p=0.689 n=6}
_{Emit Time}	_{0.32s (± 1.28%)}	_{0.32s (± 2.65%)}	_~	_0.30s	_0.32s	_{p=0.527 n=6}
_{Total Time}	_{104.09s (± 0.38%)}	_{104.07s (± 0.29%)}	_~	_103.65s	_104.44s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,789	_1,252,827	_{+38 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,991	_259,878	_{-113 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,455,040k (± 6.06%)}	_{2,455,088k (± 6.06%)}	_~	_2,393,166k	_2,759,216k	_{p=0.810 n=6}
_{Parse Time}	_{5.13s (± 0.69%)}	_{5.15s (± 1.64%)}	_~	_5.05s	_5.26s	_{p=0.809 n=6}
_{Bind Time}	_{1.83s (± 1.41%)}	_{1.83s (± 1.31%)}	_~	_1.82s	_1.88s	_{p=0.932 n=6}
_{Check Time}	_{35.54s (± 0.60%)}	_{35.48s (± 0.60%)}	_~	_35.07s	_35.66s	_{p=0.873 n=6}
_{Emit Time}	_{2.97s (± 0.85%)}	_{3.01s (± 2.50%)}	_~	_2.89s	_3.11s	_{p=0.173 n=6}
_{Total Time}	_{45.49s (± 0.51%)}	_{45.49s (± 0.59%)}	_~	_45.12s	_45.82s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,789	_1,252,827	_{+38 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,991	_259,878	_{-113 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,190,542k (± 0.02%)}	_{3,190,208k (± 0.03%)}	_~	_3,188,651k	_3,191,369k	_{p=0.378 n=6}
_{Parse Time}	_{8.44s (± 0.87%)}	_{8.43s (± 1.33%)}	_~	_8.27s	_8.57s	_{p=0.810 n=6}
_{Bind Time}	_{2.73s (± 1.12%)}	_{2.74s (± 1.21%)}	_~	_2.71s	_2.80s	_{p=0.872 n=6}
_{Check Time}	_{53.40s (± 0.45%)}	_{53.35s (± 0.28%)}	_~	_53.15s	_53.53s	_{p=0.810 n=6}
_{Emit Time}	_{4.31s (± 1.78%)}	_{4.42s (± 1.86%)}	_~	_4.29s	_4.54s	_{p=0.054 n=6}
_{Total Time}	_{68.89s (± 0.32%)}	_{68.94s (± 0.26%)}	_~	_68.80s	_69.23s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_264,703	_264,723	_{+20 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,091	_104,055	_{-36 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{443,710k (± 0.01%)}	_{443,660k (± 0.02%)}	_~	_443,580k	_443,743k	_{p=0.336 n=6}
_{Parse Time}	_{3.52s (± 0.80%)}	_{3.52s (± 0.89%)}	_~	_3.47s	_3.55s	_{p=0.687 n=6}
_{Bind Time}	_{1.37s (± 0.85%)}	_{1.37s (± 1.26%)}	_~	_1.35s	_1.40s	_{p=0.561 n=6}
_{Check Time}	_{19.17s (± 0.50%)}	_{19.18s (± 0.20%)}	_~	_19.12s	_19.22s	_{p=0.628 n=6}
_{Emit Time}	_{1.55s (± 0.82%)}	_{1.55s (± 0.82%)}	_~	_1.53s	_1.56s	_{p=1.000 n=6}
_{Total Time}	_{25.60s (± 0.39%)}	_{25.61s (± 0.13%)}	_~	_25.58s	_25.67s	_{p=0.514 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₂₇₁	₂₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,118	_225,135	_{+17 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,554	_93,521	_{-33 (- 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{370,521k (± 0.01%)}	_{370,514k (± 0.01%)}	_~	_370,475k	_370,545k	_{p=1.000 n=6}
_{Parse Time}	_{2.83s (± 1.72%)}	_{2.86s (± 0.85%)}	_~	_2.82s	_2.89s	_{p=0.147 n=6}
_{Bind Time}	_{1.63s (± 1.05%)}	_{1.65s (± 0.97%)}	_~	_1.63s	_1.67s	_{p=0.120 n=6}
_{Check Time}	_{17.39s (± 0.23%)}	_{17.48s (± 0.75%)}	_~	_17.36s	_17.67s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.85s (± 0.20%)}	_{21.99s (± 0.68%)}	_~	_21.82s	_22.18s	_{p=0.078 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_4,221,097	_4,220,890	_{-207 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,340,206	_1,339,938	_{-268 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{4,015,333k (± 0.00%)}	_{4,015,014k (± 0.01%)}	_{-319k (- 0.01%)}	_4,014,825k	_4,015,451k	_{p=0.045 n=6}
_{Parse Time}	_{16.29s (± 0.77%)}	_{16.19s (± 0.69%)}	_~	_16.03s	_16.36s	_{p=0.128 n=6}
_{Bind Time}	_{5.49s (± 0.27%)}	_{5.84s (±14.49%)}	_~	_5.46s	_7.57s	_{p=0.568 n=6}
_{Check Time}	_{121.16s (± 2.66%)}	_{123.02s (± 3.67%)}	_~	_115.21s	_129.26s	_{p=0.575 n=6}
_{Emit Time}	_{47.71s (± 5.98%)}	_{52.11s (±17.28%)}	_~	_44.91s	_67.87s	_{p=0.810 n=6}
_{Total Time}	_{190.64s (± 1.63%)}	_{197.16s (± 5.98%)}	_~	_189.99s	_220.72s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_402,249	_402,141	_{-108 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_178,120	_177,920	_{-200 (- 0.11%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{559,063k (± 0.01%)}	_{558,808k (± 0.03%)}	_{-254k (- 0.05%)}	_558,671k	_559,117k	_{p=0.045 n=6}
_{Parse Time}	_{4.74s (± 0.52%)}	_{4.76s (± 0.81%)}	_~	_4.70s	_4.81s	_{p=0.295 n=6}
_{Bind Time}	_{2.04s (± 1.26%)}	_{2.03s (± 1.10%)}	_~	_1.99s	_2.06s	_{p=0.277 n=6}
_{Check Time}	_{24.41s (± 0.82%)}	_{24.40s (± 1.24%)}	_~	_23.80s	_24.59s	_{p=0.521 n=6}
_{Emit Time}	_{0.01s (±109.43%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.282 n=6}
_{Total Time}	_{31.20s (± 0.67%)}	_{31.19s (± 1.01%)}	_~	_30.57s	_31.41s	_{p=0.810 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_731,941	_731,941	_~	_~	_~	_{p=1.000 n=6}
_Types	_219,279	_219,279	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{635,992k (± 0.01%)}	_{635,927k (± 0.01%)}	_~	_635,827k	_636,016k	_{p=0.173 n=6}
_{Parse Time}	_{4.58s (± 0.39%)}	_{4.60s (± 0.79%)}	_~	_4.55s	_4.64s	_{p=0.418 n=6}
_{Bind Time}	_{1.50s (± 0.27%)}	_{1.49s (± 0.69%)}	_~	_1.48s	_1.51s	_{p=0.257 n=6}
_{Check Time}	_{22.10s (± 0.23%)}	_{22.09s (± 0.33%)}	_~	_22.02s	_22.23s	_{p=0.573 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{28.18s (± 0.18%)}	_{28.19s (± 0.28%)}	_~	_28.07s	_28.30s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-02-06T07:27:56Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59567/merge:

Everything looks good!

Use numeric literals for BYTES_PER_ELEMENT

72142d6

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 9, 2024

RyanCavanaugh approved these changes Aug 9, 2024

View reviewed changes

Merge branch 'main' into pr-59567

16c3bb2

Copilot AI review requested due to automatic review settings February 6, 2026 06:04

Copilot started reviewing on behalf of jakebailey February 6, 2026 06:04 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

tests/baselines/reference/typedArraysCrossAssignability01.errors.txt Show resolved Hide resolved

jakebailey added 2 commits February 6, 2026 13:40

Merge branch 'main' into pr-59567

7cb29ca

Mismerged file

aac526d

Conversation

lionel-rowe commented Aug 9, 2024

Uh oh!

jakebailey commented Aug 9, 2024

Uh oh!

typescript-bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 9, 2024

Uh oh!

typescript-bot commented Aug 9, 2024

Uh oh!

typescript-bot commented Aug 9, 2024

tsc

Uh oh!

typescript-bot commented Aug 9, 2024

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

jakebailey commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

tsc

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Aug 9, 2024 •

edited

Loading

typescript-bot commented Feb 6, 2026 •

edited

Loading