-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update danger and danger plugins to latest versions #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+480
−688
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7359e7d
Initial plan
Copilot 19f11a4
Update danger from ^9.2.10 to ^13.0.5
Copilot f26be42
Add root tsconfig.json for danger's transpiler to correctly compile d…
Copilot c8ac87a
Delete tsconfig.json; use require() in dangerfile.ts instead
Copilot d329652
Update danger-plugin-spellcheck from ^1.5.0 to ^2.1.0
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| // You can test it by running | ||
| // pnpm danger pr https://github.com/microsoft/TypeScript-Website/pull/115 | ||
|
|
||
| import spellcheck from "danger-plugin-spellcheck" | ||
|
|
||
| // Blocked on PR deploys, see CI.yml | ||
| // import lighthouse from "danger-plugin-lighthouse" | ||
|
|
||
| // Spell check all the things | ||
| const { default: spellcheck } = require("danger-plugin-spellcheck") | ||
| spellcheck({ settings: "microsoft/TypeScript-Website@spellcheck.json" }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot also update the other danger plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
danger-plugin-spellcheckfrom^1.5.0to^2.1.0.danger-plugin-lighthousewas already at the latest (^0.5.2). Verifiedpnpm danger ciworks correctly with the updated plugin. (d329652)