Rename prefix/requestPrefix to input in completion APIs#2105
Merged
curtisman merged 2 commits intomicrosoft:mainfrom Mar 30, 2026
Merged
Rename prefix/requestPrefix to input in completion APIs#2105curtisman merged 2 commits intomicrosoft:mainfrom
curtisman merged 2 commits intomicrosoft:mainfrom
Conversation
Rename the parameter representing user input text from 'prefix' and 'requestPrefix' to 'input' across the completion call chain for clarity and consistency: - grammarCompletion.ts: all function params and CompletionContext field - grammarStore.ts, cache.ts, constructionStore.ts, constructionCache.ts: completion() method parameters - requestCompletion.ts: requestCompletion() parameter - matchCommandHandler.ts, requestCommandHandler.ts, translateCommandHandler.ts: local variables - completion.md: documentation signature
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the parameter representing user input text from
prefixandrequestPrefixtoinputacross the completion call chain for clarity and consistency with how callers andgrammarMatcher.tsalready name this concept.Changes
matchGrammarCompletion,collectCandidates,mergeSepMode,matchKeywordWordsFrom,findPartialKeywordInWildcard,tryPartialStringMatch) andCompletionContext.inputfieldcompletion()method parametersrequestCompletion()parameterMotivation
The old name
prefixwas ambiguous — it could mean a substring prefix of something, when it actually represents the user's input text up to the cursor. The new nameinputis:args.inputin CLI,inputin tests)grammarMatcher.tswhich usesrequestfor the same concept in the match path