Add mechanical-engineer persona, enclosure-design-review protocol, and review-enclosure template#110
Merged
Alan-Jowett merged 2 commits intomicrosoft:mainfrom Mar 29, 2026
Conversation
…d review-enclosure template Closes microsoft#109 — adds mechanical engineering capability for electronics enclosure design review. - Persona: mechanical-engineer — enclosure design, 3D printing DFM, material selection (PLA/PETG/ASA/ABS), thermal management, environmental protection (IP ratings), mounting and fastening, sensor integration, and RF considerations in enclosure design. - Protocol: enclosure-design-review (analysis) — 7-phase methodology covering PCB fit and clearance, environmental protection (IP rating, UV, condensation), thermal management, antenna/RF compatibility, sensor access, manufacturing feasibility (FDM-specific), and mounting/deployment. - Template: review-enclosure — audits enclosure design against PCB specs, requirements, and manufacturing constraints. Cross-domain verification (ME × EE × RF). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new mechanical engineering capability to PromptKit for reviewing electronics enclosure designs, extending the library’s engineering-domain coverage to include enclosure fit/DFM/thermal/environmental/RF integration.
Changes:
- Added a
mechanical-engineerpersona focused on enclosure design for electronics, materials, DFM, and cross-domain integration. - Added an
enclosure-design-reviewanalysis protocol with 7 structured phases for enclosure audits. - Added a
review-enclosuretemplate that composes the new persona + protocol and outputs aninvestigation-report; updatedmanifest.yamlto register all new components.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
personas/mechanical-engineer.md |
Introduces the mechanical engineer persona with domain focus and behavioral constraints aligned to existing persona structure. |
protocols/analysis/enclosure-design-review.md |
Adds a 7-phase analysis protocol for enclosure reviews (fit, environmental, thermal, RF, sensors, manufacturing, mounting). |
templates/review-enclosure.md |
Adds a new template that applies the protocol and produces an investigation report tailored to enclosure audits. |
manifest.yaml |
Registers the new persona, protocol, and template so the bootstrap/assembly flow can discover them. |
- Add Phase 5 (Sensor Access) explicit checklist item — was the only phase without a dedicated verification line - Add output spot-check to self-verification (re-read at least 3 findings) per self-verification protocol convention Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #109 — adds mechanical engineering capability for electronics enclosure design review. PromptKit's fourth engineering domain (software → electrical → RF → mechanical).
New Components
Protocol Phases
Cross-Domain Design
The protocol explicitly addresses cross-domain concerns:
Checklist