Skip to content

Refactor DirectLineClient for improved readability #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majdzayyad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor DirectLineClient for improved readability #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions directlineclient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@
var promise = new Promise(function(resolve, reject) {
var polling = function() {
if (retries < maxRetries) {
logger.log(`Poll messages request: ${JSON.stringify(getMessagesOptions)}`); // CodeQL [SM04580] this is a closed api that is only accessible to an internal testing service, so the ssrf risk is mitigated
axios.request(getMessagesOptions)
logger.log(`Poll messages request: ${JSON.stringify(getMessagesOptions)}`);
axios.request(getMessagesOptions) // CodeQL [SM04580] this is a closed api that is only accessible to an internal testing service, so the ssrf risk is mitigated
.then(function({ data }) {
messages = data.activities;
logger.log(`Got ${messages.length} total activities (including user's response)`);
Expand Down Expand Up @@ -143,3 +143,4 @@