feat(ScheduleFinderLive): more prominent cancelled stops#3013
Open
thecristen wants to merge 4 commits intomainfrom
Open
feat(ScheduleFinderLive): more prominent cancelled stops#3013thecristen wants to merge 4 commits intomainfrom
thecristen wants to merge 4 commits intomainfrom
Conversation
lvachon1
approved these changes
Mar 13, 2026
Contributor
lvachon1
left a comment
lvachon1
left a comment
There was a problem hiding this comment.
Thanks for fixing my bug, this looks great too!
thecristen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] All Modes: Cross out the stop name as well as the time in trip details if a stop is skipped or a trip is cancelled
This has a bonus feature of adding a small "x" marker on the skipped stop marker.
Implementation
This also fixes a bug I found that I'd missed in reviewing #3009 - sometimes alerts have
nildirection, and we should not exclude those from this page.I don't love the CSS controlling the positioning of the "x" marker, but it's no less hacky than the "T" marker showing the current stop, so, eh?
Screenshots
How to test
Look for (or create) an active alert involving a stop closure, and then find it in Schedule Finder 2.0!