Open
Conversation
… to the new SF2.0 page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Old Schedule Finder links redirect to SF 2.0
Implementation
Added a rewrite function to detect schedule finder URLs and send users to the new SF2.0 page
Screenshots
How to test
Open the old schedule finder to generate an old URL. Refresh the page or open that URL in a new tab. Observe that the new SF2.0 loads.
http://localhost:4001/schedules/CR-Providence/line?schedule_finder%5Bdirection_id%5D=0&schedule_finder%5Borigin%5D=place-NEC-1969
TODO:
Find a way to clean up the query params that are appended to the end of the URL, I appended a '#' to my URL chunk as a hack for now
Find a way to do this in a more elixir-y fashion
schedule direction variant?