feat(stop_events): add stop_events endpoint#973
Open
runkelcorey wants to merge 12 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds the following apps for a
stop_eventsendpoint:Updates the following apps:
I tried not to add any filtering or views that I'm not 100% sure we'd want, such as by parent stop or lon/lat.
This PR sets
STOP_EVENTS_ENABLEDtofalse. This exposes documentation for the endpoint but all requests will return[]data. I want to leave the actual work of connecting a data source (ideally subsituting the CDN for the S3 Mediator) to a future PR.How were these changes validated?
What questions should reviewers consider?
stop_eventsbehind some sort of feature flag? Right now it is shown but not functional withoutSTOP_EVENTS_ENABLED?