Support for customization of keychain usage (ObjC branch)#197
Open
kreuli wants to merge 4 commits intomattrubin:objcfrom
Open
Support for customization of keychain usage (ObjC branch)#197kreuli wants to merge 4 commits intomattrubin:objcfrom
kreuli wants to merge 4 commits intomattrubin:objcfrom
Conversation
added 4 commits
December 14, 2018 14:05
…ain synchronization.
kreuli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small set of changes allows for customization of how the tokens are stored in the keychain. Users can create a subclass of OTPToken and overwrite class methods to provide a custom keychain service name, define a keychain access group and also enable iCloud Keychain usage.
Defaults leave everything as before.
Additionally, a test host app has been added for the unit tests, to support keychain based tests with Xcode 10.