Allow solid_compat to be None in get_pourbaix_entries#1061
Merged
esoteric-ephemera merged 2 commits intomaterialsproject:mainfrom Feb 17, 2026
Merged
Allow solid_compat to be None in get_pourbaix_entries#1061esoteric-ephemera merged 2 commits intomaterialsproject:mainfrom
solid_compat to be None in get_pourbaix_entries#1061esoteric-ephemera merged 2 commits intomaterialsproject:mainfrom
Conversation
Collaborator
|
Thanks @lkkmpn for the fix - updated the tests to reflect the new permitted |
esoteric-ephemera
merged commit 6065af3
into
materialsproject:main
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1060 by checking whether
solid_compatisNone.